search

planetary-social / ansible-scripts

Ansible automation scripts used at Planetary
MIT License
2 stars 3 forks source link

Add event service pyroscope config #65

Closed boreq closed 7 months ago

cooldracula commented 7 months ago

This looks good to me! I have a couple of comments, but they aren't blocking I don't think. Variables are named well following our established pattern, and the work is straightforward. The only issue is with the pyroscope application name variable. It works well now, but could cause an issue in the future, setup-depending.

boreq commented 7 months ago

Sorry, I rebased this on top of main quickly without thinking about it instead of merging branches.