search

planetary-social / nos

nos.social social media for all of us, using nostr
https://nos.social
Mozilla Public License 2.0
123 stars 14 forks source link

[Follows Service iOS] Tapping on a follows notification opens the profile of the person who followed you #1447

Open setch-l opened 2 months ago

setch-l commented 2 months ago

Given that I am a user of Nos When I tap on a follow notification Then it should open the profile of the person who followed my account

Notes from Daniel: Read notification metadata so that tapping on it opens the correct profile (iOS team)

dcadenas commented 2 months ago

@mplorentz I've been thinking about changing the message payload to make it easier to bundle multiple followers. I plan to update the payload to include two arrays of objects containing npubs, one for follows and one for unfollows. This is pending work, so it might be best to wait until it's done, but there may be tasks you can start on now. It's on my task list here.

I'll use this new payload for single-follower notifications as well, including the friendly ID in the text. For aggregations, the text will just show follow/unfollow counts, but both will use the same payload.

dcadenas commented 2 months ago

@mplorentz I think I unblock you with this PR https://github.com/planetary-social/nos-notification-service-go/pull/64

setch-l commented 1 month ago

@bryanmontz - The AC for this said to open the profile for the user. Instead I'm taken to the Notifications tab.

See video https://github.com/user-attachments/assets/48122bb5-4865-4cf4-9179-a82e574a6905

bryanmontz commented 1 month ago

@setch-l What build was that on? Are you 100% sure that the code for this was part of that build? I'm asking bc in the video it doesn't look like anything happens at all as a result of tapping the notification. It works for me, both in the simulator and in the latest TestFlight build (0.1.27 (278)), even when the side menu is open while the app is backgrounded like yours was in the video. Here's a video from my device. I cut it off before it loaded everything, but it did eventually load the profile and some notes.

push-profile

dcadenas commented 1 month ago

Hey Bryan that was done on my phone. I’m on 279 right now. I don’t recall if yesterday it was with 278, maybe a regression ?

On Sat, 28 Sep 2024 at 10:08 Bryan Montz @.***> wrote:

@setch-l https://github.com/setch-l What build was that on? Are you 100% sure that the code for this was part of that build? I'm asking bc in the video it doesn't look like anything happens at all as a result of tapping the notification. It works for me, both in the simulator and in the latest TestFlight build (0.1.27 (278)), even when the side menu is open while the app is backgrounded like yours was in the video. Here's a video from my device. I cut it off before it loaded everything, but it did eventually load the profile and some notes.

push-profile.gif (view on web) https://github.com/user-attachments/assets/19e071a2-d95d-4234-bb17-c266276df56e

— Reply to this email directly, view it on GitHub https://github.com/planetary-social/nos/issues/1447#issuecomment-2380634718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEOCD6YHY6OKW45OF7GH3ZY2S4VAVCNFSM6AAAAABNM3PXZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBQGYZTINZRHA . You are receiving this because you commented.Message ID: @.***>