search

planetary-social / nos

nos.social social media for all of us, using nostr
https://nos.social
Mozilla Public License 2.0
122 stars 14 forks source link

[Crash] when tapping on a repost #1669

Open mplorentz opened 1 week ago

mplorentz commented 1 week ago

Describe the bug

A crash in Router.swift:67 when tapping on a repost.

To Reproduce

None yet

Screenshots or Video

If applicable, add screenshots or video to help explain your problem.

Technical info

Additional context

Slack report one (with logs) testflight crash log one Slack report two (with logs) testflight crash log two Sentry issue

The crash is on the line fatalError("Tried to push a note with no identifier; that's not going to work."). Probably this should just be an assertion failure? But we still need to fix whatever code is creating a note with no identifier.

It's weird that the crashes reported in slack and testflight don't match up with the ones in Sentry.

bryanmontz commented 4 days ago

This should definitely be assertionFailure(_:) instead, so that it only crashes in dev and not production.

pelumy commented 4 days ago

Thanks for the tip @bryanmontz.