search

planetary-social / nos

nos.social social media for all of us, using nostr
https://nos.social
Mozilla Public License 2.0
123 stars 14 forks source link

Fix Search bar disappearing on Discover tab when scrolling #1680

Closed pelumy closed 1 month ago

pelumy commented 1 month ago

Issues covered

1679

Description

This PR fixes the Search bar disappearing on Discover tab when scrolling. This is fixed by using the custom SearchBar instead of Apple's .isSearchable modifier.

How to test

  1. Navigate to the discover tab.
  2. Scroll through the recommended profiles.
  3. Please check that the search bar is still visible and doesn't disappear.
  4. Go to a different tab and switch back to the discover tab.
  5. Please check that the search bar is still visible after switching back.

Screenshots/Video

Before After
Before After
mplorentz commented 1 month ago

👀

mplorentz commented 1 month ago

I fixed up the fonts. I ended up using the .placeholder modifier that we already had because it was simpler than adding more parameters to PlaceholderModifier. Let me know what you think! But I'm going to go ahead and merge this so we can get into the App Store review queue!

pelumy commented 1 month ago

I love the new approach and I feel it is cleaner. We should change the other place where the modifier was used after the launch. Thanks for fixing this @mplorentz.