Fix race condition in SocialGraphTests

planetary-social / nos

nos.social social media for all of us, using nostr

https://nos.social

Mozilla Public License 2.0

120 stars 14 forks source link

Fix race condition in SocialGraphTests #671

Open mplorentz opened 10 months ago

mplorentz commented 10 months ago

Some of the SocialGraphTests fail intermittently. We need to figure out why and get them fixed, it could be indicating a real bug.

The tests we have seen fail are:

testFollow
testOneFollower
testTwoFollows
testOutOfNetwork

joshuatbrown commented 4 months ago

Unfortunately, the XCTExpectFailure is insufficient for our CI -- still the tests fail and block PRs from merging, as you can see here. I'm going to disable the tests for now so we can avoid having PRs blocked by tests that intermittently fail.

joshuatbrown commented 4 months ago

I've updated my Discover tab PR to disable the tests -- for real -- so we don't start ignoring test failures.