Closed mplorentz closed 1 year ago
@chereseeriepa @mixmix is this the intended behavior based on the publicWebHosting spec you wrote up?
Not the intended behaviour at all, it shouldnt be showing profiles. I checked and realised i missed a publicWebHosting check in the new threads query I wrote recently. Thats all fixed now in this PR: https://github.com/planetary-social/planetary-graphql/pull/53
I will look further into this, to see if these changes were enough to fix it :)
Another part i missed was this: https://github.com/planetary-social/planetary-graphql/commit/1a8f158610b558a3737ff2a37e3b93447e720966
Adding a check for public web hosting here and dropping any thread started by someone with publicWebHosting==false
means that I dont think we can not display any messages like this:
this is because the pagination step needs a message id, and messages like this contain no message id.
Issue is addressed in: https://github.com/planetary-social/rooms-frontend/issues/131
This is something that @rabble noticed that we are showing picture, name, and contacts for people who have opted out of public we hosting. We should instead show a message that this is a valid profile but they have chosen not to be hosted publicly.