search

planetary-social / rooms-frontend

MIT License
4 stars 2 forks source link

image serving on firefox broken? #140

Open mixmix opened 1 year ago

mixmix commented 1 year ago

Here's another thing I found running through user flows... there's some client code bug for image display in Firefox. The images display in Brave/Chromium and Safari, just fine. Image shows Firefox on the left w/ broken images, Brave is on the left.

Image

(reported by @danlatorre https://github.com/planetary-social/rooms-frontend/issues/138#issuecomment-1453895551)

mixmix commented 1 year ago

@danlatorre I'm unable to reproduce

Loading your profile in firefox : https://planetary.name/profile/@GCSmjLHmFC8m9t0ouJ6cY4tzlQdIbBaQfI0Uifw5cZA=.ed25519

image

image

mixmix commented 1 year ago

Can you post more about what version of Firefox, and the link to that profile. In general always share the URL if you can, it makes testing + debugging way easier :heart:

rabble commented 1 year ago

I'm pretty sure that images are broken inconsistently because it's planetary-graphql that's serving images and NOT nginx directly. This could also be why the graphql server sometimes just fails to respond for minutes at a time. under no condition should we be serving blobs from planetary-graphql. these need to be moved to be directly served from nginx.

mplorentz commented 1 year ago

under no condition should we be serving blobs from planetary-graphql.

@rabble I don't understand why you say this. Can you explain why you think this is necessarily slow? In theory having nginx ask planetary-graphql should only add microseconds to the overall fetch time, which is insignificant to the milliseconds it takes to transfer a blob across the network to the browser. What am I missing?

@cooldracula was talking about migrating to a single nginx instance in the future rather than having each server run its own, which seems like a good idea to me. If we change to having nginx serve the blobs directly from disk then we still need to run nginx on every box.