AndrewAnnex
commented
3 years ago *updated with anonymous reviewer comments 05/21/2021* *updated testing score 05/22/2021* This package has been reviewed for inclusion in the PlanetaryPy affiliated package ecosystem by a member of the PlanetaryPy community as well as myself, and I have synthesized the results of the review here.
You can find out more about our review criteria in Reviewing affiliated packages. For each of the review categories below we have listed the score and have included some comments when the score is not green.
| Functionality/Scope |
|
Anonymous reviewer stated that kalasiris did not provided enough added value over pysis or bash scripting for them personally. Review coordinator notes that review guidelines are broadly defined, and notes the potential of added-value capabilities. | |
| Integration with PlanetaryPy ecosystem |
|
Anonymous reviewer pointed out the existence of pysis causing kalasiris to potentially be in conflict with the objective of ecointegration. Anonymous reviewer goes on to note the lack of an established user base for kalasiris relative to pysis. Anonymous reviewer however also noted the lack of activity on pysis, and that kalasiris stands a better chance of being developed further, justifying approval to the reviewer. Review coordinator notes that pysis is not currently affiliated with planetarypy, so kalasiris meets the definition of establishing base functionality in the planetarypy ecosystem specifically. | |
| Documentation |
|
| Review coordinator: I think more examples in the documentation outside of the quickstart could demonstrate the additional benefits/features of kalasiris such as `k_funcs` more visibly to new users. | |
| Testing |
|
| No further comments | |
| Development status |
|
| No further comments | |
| Python version compatibility |
|
| No further comments | |
Summary/Decision: This package meets the review criteria for affiliated packages, so we are happy to confirm that we'll be listing your package as an affiliated package! Keep up the good work, and we encourage you to improve on the areas above that weren't "green" yet.
If you have any follow-up questions or disagree with any of the comments above, leave a comment and we can discuss it here. At any point in future you can request a re-review of the package if you believe any of the scores should be updated - contact the coordination committee, and we’ll do a new review.
rbeyer
the 1st external reviewer declined to review kalasiris. Waiting to hear from the alternate.