search

planetarypy / TC

PlanetaryPy Project Technical Committee
https://planetarypy.org/
1 stars 2 forks source link

Added a bunch of governance documents relevant to the PSO application #6

Closed rbeyer closed 4 years ago

michaelaye commented 4 years ago

I guess we can merge it or do you want a second review?

rbeyer commented 4 years ago

We don't currently have a rule in place for two reviews, but the changes I'm suggesting would put that rule in place. Let's see if we can get a second review.

AndrewAnnex commented 4 years ago

Sounds good to me, away from my computer atm but can approve changes later

-Andrew Annex

On Nov 27, 2019, at 2:23 PM, K.-Michael Aye notifications@github.com wrote:

 @michaelaye commented on this pull request.

In Contributing.md:

+how to get it merged or if it should merge, then it should be escalated +to the TC. TC members should regularly discuss pending contributions +in order to find a resolution. It is expected that only a small +minority of issues be brought to the TC for resolution and that +discussion and compromise among committers be the default resolution +mechanism. + +Exceptions to the above are minor typo fixes or cosmetic changes +that don't alter the meaning of a document. Those edits can be +made via a PR which only requires a single approval (not two, and +not open for 24 h) to be merged. + + +# Becoming a Committer + +All contributors who get a non-trivial contribution merged should Good points, thanks.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

AndrewAnnex commented 4 years ago

@rbeyer should I merge this?

rbeyer commented 4 years ago

Yes.

So at this point, anyone could hit the 'merge' button (including me), since it has two approvals.