Planetary/PDS tools moving foward

[percurnicus]

@spacerockjock

I'm about to get stared on a mer_spect equivalent (exportable ROIS, polygon ROIs, multiple ROIs, etc.) and everything is pointing to the fact that both pdsview and pdsspect (temporary name...have not thought about the name...) should depend on the very similar models and (also repeated use of the histogram tool). Essentially, pdsspect will be a more complicated tool than pdsview and will subclass and reuse a lot of pdsview's classes and tools. I could do this by making a new package for pdsspect and making pdsview a dependency, create pdsspect within pdsview, or start a new package that will house pdsview, pystamps, pdsspect, and any other future tools we create and deprecate pdsview and pystamps. My problem with the first option is it will become clearer as I make pdsspect how pdsview can be refactored even more to make it easier to reuse code. Then I will have simultaneous development on the two projects and that points me to option 2 or 3. My problem with option 2 is then pdsview is not clear on its purpose. The way it is setup/named right now is it is a one tool package and it won't be clear that there are other tools available. Which leads me to option 3 which I think is most preferable. It will be clear on it's purposes, allow for tools to reuse and sublcass each other much more easily, and make it far easier for the tools to interact/launch each other. The main concern is this will cause some reorganization on PlanetaryPy and we will have to take pdsview of of pip. I don't want to make any decisions about these tools moving forward alone and would love input on what people think is best moving forward.

[godber]

It's unclear what option 3 is. Are these the three options?

1. make a new package for pdsspect and making pdsview a dependency
2. create pdsspect within pdsview,
3. start a new package that will house pdsview, pystamps, pdsspect, and any other future tools we create and deprecate pdsview and pystamps.

[godber]

I think there is a 4th option. Create a library package shared by all three UI tools. As you're developing pyspect and identifying reusable code you extract it into this library, and modify pdsview to use the newly extracted code.

[percurnicus]

Yes those are the three options but I like the fourth option!

[spacerockjock]

I will weigh in on the newly offered Option #4.

Ernest

On 6/9/17 6:57 AM, Perry Vargas wrote:

Yes those are the three options but I like the fourth option!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_planetarypy_pdsview_issues_45-23issuecomment-2D307395899&d=DwMCaQ&c=AGbYxfJbXK67KfXyGqyv2Ejiz41FqQuZFk4A-1IxfAU&r=bGQ0e5FmNwkJc9bxO2gEeGP3Y7-NuKum9VD6w32Mk9Y&m=RjTNmmLq5wQccNUBY5QZd6ud9bcos0Ds7-k6GeXaMp8&s=6LFsjhbXeySLl8AGpCFPatr4ilJ_-00pVMBf7dXlJuQ&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AaHUxehGomkfPW9cqUqdy-5FDrb6Ft5-5FZlks5sCU9OgaJpZM4Ny8wk&d=DwMCaQ&c=AGbYxfJbXK67KfXyGqyv2Ejiz41FqQuZFk4A-1IxfAU&r=bGQ0e5FmNwkJc9bxO2gEeGP3Y7-NuKum9VD6w32Mk9Y&m=RjTNmmLq5wQccNUBY5QZd6ud9bcos0Ds7-k6GeXaMp8&s=XgxlStrm50_yqqoOj4Z5KIkcxgkEvPaRfRWp8JdcKrw&e=.

--

Ernest Cisneros

Arizona State University School for Earth and Space Exploration Box 876004 Tempe, AZ 85287-6004

Office: ISTB-4 Bldg, 631B Phone: 480-965-6187 Email: ecisneros@asu.edu FAX: 480-965-8102