planetarypy / planetaryimage

Python PDS and Isis Cube file parser.
BSD 3-Clause "New" or "Revised" License
39 stars 20 forks source link

Added Write Support in the PDS3Image. #48

Closed bvnayak closed 8 years ago

bvnayak commented 8 years ago

refs#45

godber commented 8 years ago

All of the sudden all Python 3 tests are erroring with:

urllib.error.HTTPError: HTTP Error 403: Forbidden

I went back and reran the previously passed v0.3.0 test for 3.5 and it now fails. Maybe the IP from which the 3+ tests are running is now being blocked by PDS due to repeating requests or something.

godber commented 8 years ago

We may have to mirror our test data ourselves.

bvnayak commented 8 years ago

Tasks to be performed in this ticket:

  1. Write tests after adding 'save' support.
  2. I swapped the byte-order in case of 3-band Images. I will fetch the byte order information from the label now and then will swap if its required.
godber commented 8 years ago

@bvnayak you can ignore these comments until next week, since I know you're studying.

I have a number of concerns with this PR:

Lastly, I've realized that many of our tests for pds3image are implemented incorrectly. They should be testing image.label and image.data. They mostly test the convenience properties that should maybe be considered internal and changed to band -> _band. But at the very least, label values need to be tested explicitly since that's the interface users should be using. Please modify your new tests here to include tests of image.label and image.data. I will file another ticket to change the older tests.

bvnayak commented 8 years ago

Added the write support on the updated master branch. Closing this.