search

planetarypy / planetaryimage

Python PDS and Isis Cube file parser.
BSD 3-Clause "New" or "Revised" License
39 stars 20 forks source link

Issue#60 pds3 image object from numpy array #65

Closed bvnayak closed 8 years ago

godber commented 8 years ago

Good progress @bvnayak! My initial reactions are

  1. Perhaps the interface for array data should be PDS3Image(data) instead of PDS3Image.open(data). Is there any benefit to using open?
  2. I think your test would seem more direct and be more informative to users if you manually created the numpy array rather than reading it from a file.
  3. More tests could be implemented to test other parts of the code by creating a variety of different arrays.
wtolson commented 8 years ago

@godber That's similar to what I was thinking: https://github.com/wtolson/planetaryimage/blob/plugin-refactor/planetaryimage/image.py#L26

godber commented 8 years ago

@wtolson ... Bhavin and I have both played with that branch at this point and may fiddle with it further. We're addressing some internal needs right now and then will regroup and look at your plugin based approach.

bvnayak commented 8 years ago

More tests on different dtypes are coming soon !