planetarypy / pvl

Python implementation of PVL (Parameter Value Language)

BSD 3-Clause "New" or "Revised" License

19 stars 19 forks source link

Set ASCII NULL characters as "reserved" for default parsing. #102

Closed rbeyer closed 2 years ago

rbeyer commented 2 years ago

Description

The default "Omni" parsing strategy, now considers the ASCII NULL character ("\0") a "reserved character." The practical effect is that the ASCII NULL can not be in parameter names or unquoted strings (but would still be successfully parsed in quoted strings). This means that PVL-text that might have incorrectly used ASCII NULLs as delimiters will once again be consumed by our omnivorous parser.

Related Issue

Would close #98

How Has This Been Tested?

make lint
make docs

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the pvl project uses.

codecov[bot] commented 2 years ago

Codecov Report

Merging #102 (1d06c23) into main (7614c01) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files          12       12           
  Lines        1941     1941           
=======================================
  Hits         1842     1842           
  Misses         99       99

Impacted Files	Coverage Δ
pvl/grammar.py	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7614c01...1d06c23. Read the comment docs.