planetarypy / pvl

Python implementation of PVL (Parameter Value Language)
BSD 3-Clause "New" or "Revised" License
19 stars 19 forks source link

Remove request of next token after end-statement #105

Closed rbeyer closed 2 years ago

rbeyer commented 2 years ago

This bugfix removes the behavior in which the parser successfully parses and end-statement, and then requests the next token. The intended behavior was to leave a hook for future parsing of a comment that could come after the end-statement. However, in some rare cases, this request of another token could hang the whole process, and since nothing was done with the returned token, removing the request has no impact at this time.

I also added Python 3.10 to our GitHub Python testing workflow matrix.

Related Issue

Issue #104

How Has This Been Tested?

Types of changes

Checklist:

Licensing:

This project is released under the LICENSE.

codecov[bot] commented 2 years ago

Codecov Report

Merging #105 (8f34f0d) into main (326748c) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   94.89%   94.93%   +0.03%     
==========================================
  Files          12       12              
  Lines        1941     1933       -8     
==========================================
- Hits         1842     1835       -7     
+ Misses         99       98       -1     
Impacted Files Coverage Δ
pvl/parser.py 96.63% <ø> (+0.21%) :arrow_up:
pvl/__init__.py 96.15% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more