search

planetarypy / pvl

Python implementation of PVL (Parameter Value Language)
BSD 3-Clause "New" or "Revised" License
19 stars 19 forks source link

Bugfix for scientific notation #48

Closed rbeyer closed 4 years ago

rbeyer commented 4 years ago

@michaelaye noted that he had trouble with a particular label. Turns out that we weren't parsing scientific notation completely correctly. We did fine with '1e2' or '1e-2', but since '+' is a reserved character in PVL, '1e+2' got broken up on the plus.

This fixes that, and also catches an error properly that wasn't being caught. The test label that @michaelaye shared now parses correctly with pvl.load() and also with pvl_validate.

michaelaye commented 4 years ago

Can confirm things work here now.

rbeyer commented 4 years ago

Can confirm things work here now.

Good, can I get an approval here, then?

michaelaye commented 4 years ago

i don't know how, don't see any button where i can approve something?

michaelaye commented 4 years ago

i think you didn't ask for approval on GH, can that be?

michaelaye commented 4 years ago

i only have the merge button ready to go...

rbeyer commented 4 years ago

Ah, so if you don't explicitly 'request' a review from someone, anyone can still leave a review (and hence an 'approve') by clicking on the 'files changed' link at the top. Then you'll get the 'Review Changes' button at the upper-right. Not obvious, truly.

rbeyer commented 4 years ago

Great. We'll let this sit for 24h, then we can merge it (might as well adopt our PlanetaryPy contributing guidelines), and then I'll rebase #46 on this new master.