datetime aware refinement

rbeyer commented 4 years ago

Description

Enforced that all datetime.time and datetime.datetime objects returned should be timezone "aware." This breaks 0.x functionality where some were and some weren't.

Related Issue

Closes #57

Motivation and Context

See detailed discussion in #57

How Has This Been Tested?

make lint
make docs
make test

Types of changes

Breaking change (previously, the datetime objects returned by the 0.x architecture were not uniform, sometimes they were aware sometimes they were not.)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the pvl project uses.

rbeyer commented 4 years ago

Hmm, looks like I'm having errors in Travis. I'll troubleshoot this.

michaelaye commented 4 years ago

I have indeed seen seconds of 60.x in a broken translation between spacecraft and UTC time. and datetime was totally fine with it, it's bizarre.

planetarypy / pvl