planetarypy / pvl

Python implementation of PVL (Parameter Value Language)
BSD 3-Clause "New" or "Revised" License
19 stars 19 forks source link

We were decoding UTF-8, but not latin-1. #94

Closed rbeyer closed 3 years ago

rbeyer commented 3 years ago

Description

If the PVL-text was not decodable as UTF-8, then all characters at and after the non-UTF-8 character were not considered as part of the PVL-text for parsing. Characters encoded in latin-1 (ISO/IEC 8859-1) should be considered (and don't code as UTF-8), and now are.

Related Issue

Fixes #93

How Has This Been Tested?

Types of changes

Checklist:

Licensing:

This project is released under the LICENSE.

codecov[bot] commented 3 years ago

Codecov Report

Merging #94 (6d15567) into main (1a1b41b) will increase coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   94.85%   94.97%   +0.11%     
==========================================
  Files          12       12              
  Lines        1925     1929       +4     
==========================================
+ Hits         1826     1832       +6     
+ Misses         99       97       -2     
Impacted Files Coverage Δ
pvl/__init__.py 96.15% <100.00%> (+1.41%) :arrow_up:
pvl/grammar.py 100.00% <100.00%> (ø)
pvl/lexer.py 99.23% <0.00%> (-0.77%) :arrow_down:
pvl/parser.py 96.90% <0.00%> (+0.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a1b41b...6d15567. Read the comment docs.