search

planetdecred / dcrios

Decred Mobile Wallet for IOS
ISC License
25 stars 27 forks source link

add info icon to explain transaction byte size #876

Closed dreacot closed 2 years ago

dreacot commented 2 years ago

Resolves #868

This PR adds an info icon that explains how the transaction byte size is determined

Screenshots
JustinBeBoy commented 2 years ago

I think we should use the same dialog as we used in app for it

dreacot commented 2 years ago

I think we should use the same dialog as we used in app for it

Any particular reason we should use this one?

I believe we are meant to use custom dialogs throughout as in the mockups?

JustinBeBoy commented 2 years ago

I think we should use the same dialog as we used in app for it

Any particular reason we should use this one?

I believe we are meant to use custom dialogs throughout as in the mockups?

Okay, so I think margin top of title must be large more, and we should change all dialogs to the custom dialog

dreacot commented 2 years ago

I think we should use the same dialog as we used in app for it

Any particular reason we should use this one? I believe we are meant to use custom dialogs throughout as in the mockups?

Okay, so I think margin top of title must be large more, and we should change all dialogs to the custom dialog

Yeah the top margin needs to be more, and yeah, we can integrate the change for all dialog

Please create an issue for that

Also for the top margin, that should be another issue, as the dialog wasn't created in this PR, i just reused what was existing