search

planetfederal / django-osgeo-importer

Do not use this repo, use https://github.com/GeoNode/django-osgeo-importer
GNU General Public License v3.0
2 stars 1 forks source link

Multifile upload support #20

Closed sarasafavi closed 8 years ago

sarasafavi commented 8 years ago

Reference @bitner's original PR at https://github.com/ProminentEdge/django-osgeo-importer/pull/39

Adds "multifile" support to the upload process: now, multiple files can be selected after clicking "choose file(s)" on the "Add data" page. This allows upload of multiple layers at once, as well as uploading of unzipped shapefiles. A single upload can include any number of files in any mix of (supported) formats.

I've also removed the outdated list of "Valid file types" from the "Add data" page's template (ref: https://github.com/boundlessgeo/django-osgeo-importer/issues/19). This is equivalent to Exchange's current default importer (that is, no explicit list of supported file types is shown to the user at this point in the upload process), which seems acceptable at this point in development.

ghost commented 8 years ago

This is exciting but I'm too tired to review it tonight, tomorrow we'll dig in more and exercise it

ghost commented 8 years ago

My feedback on this is pretty trivial, I think it looks good.

I think we should improve test coverage beyond this, but I don't think that should be a barrier to merge

sarasafavi commented 8 years ago

An edge-case bug has been logged at https://github.com/boundlessgeo/django-osgeo-importer/issues/24, but I don't see this as a blocker to getting this merged in; #24 can (and should) be worked in a separate PR

sarasafavi commented 8 years ago

@harts-boundless reviewed your latest, looks good! I'm fine with merging if you are.

ghost commented 8 years ago

This runs fine for me manually and all tests are passing. Your recent additions look clean too. I'm gonna merge it.