planetfederal / geodroid-server

Apache License 2.0
3 stars 4 forks source link

layer page should respect lifecycle and cancel background task #29

Closed ischneider closed 10 years ago

ischneider commented 10 years ago

Looks like the layer page should override the onPause method and cancel the background LoadLayers task.

While this doesn't appear to cause problems, it does cause a lot of logging.

Assigning to me as I have a fix.

11-19 23:56:50.528: W/GeodroidServer(12881): java.lang.NullPointerException 11-19 23:56:50.528: W/GeodroidServer(12881): at android.preference.PreferenceManager.getDefaultSharedPreferencesName(PreferenceManager.java:371) 11-19 23:56:50.528: W/GeodroidServer(12881): at android.preference.PreferenceManager.getDefaultSharedPreferences(PreferenceManager.java:366) 11-19 23:56:50.528: W/GeodroidServer(12881): at org.geodroid.server.Preferences.(Preferences.java:24) 11-19 23:56:50.528: W/GeodroidServer(12881): at org.geodroid.server.PageFragment.getPreferences(PageFragment.java:69) 11-19 23:56:50.528: W/GeodroidServer(12881): at org.geodroid.server.LayersPage$LoadLayers$1.visit(LayersPage.java:277) 11-19 23:56:50.528: W/GeodroidServer(12881): at org.geodroid.server.LayersPage$DatasetVisitor.process(LayersPage.java:343) 11-19 23:56:50.528: W/GeodroidServer(12881): at org.geodroid.server.LayersPage$LoadLayers.doInBackground(LayersPage.java:230) 11-19 23:56:50.528: W/GeodroidServer(12881): at org.geodroid.server.LayersPage$LoadLayers.doInBackground(LayersPage.java:199)