search

planetfederal / geogig-py

A Python library to use GeoGit
BSD 3-Clause "New" or "Revised" License
24 stars 14 forks source link

Use Python geo interface instead of Shapely objects #27

Open sgillies opened 10 years ago

sgillies commented 10 years ago

Hi there, this is a good looking project and I have a little suggestion. You may want to consider having a feature's geometry be not a Shapely geometry object, but instead be a GeoJSON-ish dictionary or other object that implements the Python geo interface. There's some overhead to Shapely object creation that some users may want to avoid and Shapely objects would remain super easy to get for anyone that needed them: shapely.geometry.shape(feature.geom).

cleder commented 10 years ago

+1 the geo_interface is now widely adopted. if this removes the dependency on a specific library its ++1