planetfederal / geoserver-exts

Other
31 stars 40 forks source link

support geonode - allow importid to be specified #5

Closed ischneider closed 12 years ago

ischneider commented 12 years ago
ischneider commented 12 years ago

My only concern was implementing save on the memory store - if object references are shared (and not obtained from the store each time a read/write is needed), this might impact other parts not tested. All tests passed when ran, FWIW.

jdeolive commented 12 years ago

Looks good to me. +1

Regarding shared object references indeed this is a potential issue. Solutions would be to either clone objects passed back or use some sort of proxying mechanism like we do for the in memory geoserver catalog.