planetfederal / gxp

High level components for GeoExt based applications.
http://boundlessgeo.com/
Other
84 stars 97 forks source link

GetFeatureInfo triggered when panning map if Bing layer loaded #113

Closed bmcbride closed 12 years ago

bmcbride commented 12 years ago

If a viewer contains a Bing layer, and you have the GetFeatureInfo tool active, it will trigger a getfeatureinfo request when you drag the map. This happens even of the Bing layer is not the active baselayer. You can replicate this issue in GeoExplorer at http://suite.opengeo.org/geoexplorer/composer

1) Add a WMS layer 2) Add a Bing layer 3) Activate the Get Feature Info tool 4) Pan around the map- notice the Feature Info popup 5) Remove Bing layer and proper functionality is restored

bartvde commented 12 years ago

I've confirmed this is an issue with the latest as well.

bartvde commented 12 years ago

The click Handler in OpenLayers is somehow triggering the click callback when panning.

bartvde commented 12 years ago

This seems to be caused by the updateAttribution function of the Bing layer.

bartvde commented 12 years ago

@bmcbride it seems this OpenLayers fix has fixed this issue as well: https://github.com/openlayers/openlayers/commit/56e25fc9fe9391121f1aeff77c41e8e29c713ac8

Are you able to verify? TIA.

bartvde commented 12 years ago

Maybe not that specific commit but an update to OpenLayers master fixed things for me.

bmcbride commented 12 years ago

Updated to OpenLayers master and gxp master and all seems to be working well. Thanks Bart!