planetfederal / gxp

High level components for GeoExt based applications.
http://boundlessgeo.com/
Other
84 stars 97 forks source link

featureeditor: do not create GeoExt popups without a location #130

Closed bartvde closed 12 years ago

bartvde commented 12 years ago

currently we have the ability to create events (i.e. features with no geometry). However when displaying their popups we get a javascript error:

px is null
http://localhost:8081/script/@/app/static/externals/openlayers/lib/OpenLayers/Map.js
Line 2488

This is because we are creating a GeoExt.popup with a feature with no geometry.

bartvde commented 12 years ago

The best way to solve this is probably in GeoExt.popup, don't do anything in the position function if there is no location.

bartvde commented 12 years ago

See: https://github.com/geoext/geoext/pull/34