search

planetfederal / gxp

High level components for GeoExt based applications.
http://boundlessgeo.com/
Other
84 stars 97 forks source link

ability to pass in customRenderers to WMSGetFeatureInfo is broken #162

Closed bartvde closed 12 years ago

bartvde commented 12 years ago

as reported by @ pvgenuchten

hi bart, just found out some of my code does not work any more agaist gxp master

In this commit https://github.com/opengeo/gxp/commit/f5276cc3634f8aebc53879bb56923abff532e8fa Matt converted propertygrind to featureeeditorgrid in featureinfo popup

i use sometimes itemConfig:{customRenderers:.. in wms-getfeatureinfo plugin configuration, which are now overwritten in featureeeditorgrid-initialisation

My code works again if I change line 87 in featureeditorgrid.js to customRenderers = this.customRenderers||{},

Is this something to integrate in master? Or is it better to apply these renderers via wmssource as done for propertynames?

note that now date is already overwritten anyway