search

planetfederal / gxp

High level components for GeoExt based applications.
http://boundlessgeo.com/
Other
84 stars 97 forks source link

Modify layout of FeedSourceDialog; make YouTube and Picasa feedsources mandatory #178

Closed mbertrand closed 11 years ago

mbertrand commented 11 years ago

Reduce width of FeedSourceDialog fields (too wide for GeoNode).

Make YouTubeFeedSource and PicasaFeedSource required instead of optional for FeedSourceDialog (no other way to get them into packaged version of GeoExplorer included with GeoNode?)

bartvde commented 11 years ago

@mbertrand if you can make the small changes then this is good to go, TIA

mbertrand commented 11 years ago

Hi @bartvde, any more changes you'd like me to make to the code for this PR?

bartvde commented 11 years ago

thanks for the ping @mbertrand I did not get notifications from your commits so good that you put a comment with my github username, let me do a final check now and then merge.

bartvde commented 11 years ago

@mbertrand can you please fix these jslint errors:

src/script/widgets/FeedSourceDialog.js|200| lint warning: missing semicolon
src/script/widgets/FeedSourceDialog.js|203| lint warning: missing semicolon

src/script/plugins/AddLayers.js|402| lint warning: missing semicolon
src/script/plugins/AddLayers.js|409| lint warning: empty statement or extra semicolon