search

planetfederal / qgis-geogig-plugin

A plugin to manage and use GeoGig repositories from QGIS
GNU General Public License v2.0
9 stars 8 forks source link

Improve mechanism used for Java JRE #1

Open volaya opened 8 years ago

volaya commented 8 years ago

Currently, it's shipped with the plugin and assumed to be in the plugin foder, but users might have a previously installed JRE. In this case, it would be good to use it instead, to reduce the size of the plugin bundle

luipir commented 8 years ago

last Alex modification works on Linux... under Linux no need of JRE packaged with the plugin

patche is this one: https://github.com/boundlessgeo/qgis-geogig-plugin/commit/67d2aa74267ee5957cbc4e1bc5590eced3471ad1

alexbruy commented 8 years ago

IMO we should drop other JREs from plugin package and use system-wide one. We can use some heuristic to setup JRE path and also allow user to change it manually, something similar to Processing. Same can be applied to GeoGig binaries.

So plugin package will be much smaller and can be published in the official repository too.

volaya commented 8 years ago

The issue with that is that the little testing we did with external testers proved that most of them where not capable of configuring Java and/or GeoGig. We need an out-of-the box solution...and letting the user configure that automatically will cause a lot of support requests...

Much better is the idea of installing that from the plugin itself, so the plugin downloads JRE and GeoGig

On Wed, Dec 16, 2015 at 10:15 AM, Alexander Bruy notifications@github.com wrote:

IMO we should drop other JREs from plugin package and use system-wide one. We can use some heuristic to setup JRE path and also allow user to change it manually, something similar to Processing. Same can be applied to GeoGig binaries.

So plugin package will be much smaller and can be published in the official repository too.

— Reply to this email directly or view it on GitHub https://github.com/boundlessgeo/qgis-geogig-plugin/issues/1#issuecomment-165042624 .

Victor Olaya Software Engineer | Boundless http://boundlessgeo.com/ volaya@boundlessgeo.com @boundlessgeo http://twitter.com/boundlessgeo/

alexbruy commented 8 years ago

But even with this approach we still need in some way to check if JRE and GeoGig already installed and allow to use this installed versions instead of downloading and installing second instance

volaya commented 8 years ago

What we had discussed was allowing downloading JRE and GeoGig, but only in the plugin folder, as embedded. So if you do not have geogig and JRE there, it will install them there (even if you have other versions in your system...). That should make it less complicated to install, since the mechanism is less flexible

On Wed, Dec 16, 2015 at 2:41 PM, Alexander Bruy notifications@github.com wrote:

But even with this approach we still need in some way to check if JRE and GeoGig already installed and allow to use this installed versions instead of downloading and installing second instance

— Reply to this email directly or view it on GitHub https://github.com/boundlessgeo/qgis-geogig-plugin/issues/1#issuecomment-165108893 .

Victor Olaya Software Engineer | Boundless http://boundlessgeo.com/ volaya@boundlessgeo.com @boundlessgeo http://twitter.com/boundlessgeo/