planetfederal / qgis-geogig-plugin

A plugin to manage and use GeoGig repositories from QGIS
GNU General Public License v2.0
9 stars 8 forks source link

exception when: After add layer => "show changes introduced by this version" #7

Closed luipir closed 8 years ago

luipir commented 8 years ago

jus added layer bikepbx, then "show changes introduced by this version" genraqte the following exception in console:

Traceback (most recent call last): File "/home/ginetto/.qgis2/python/plugins/geogig/gui/dialogs/historyviewer.py", line 103, in diffAction.triggered.connect(lambda: self.showDiffs(item.commit)) File "/home/ginetto/.qgis2/python/plugins/geogig/gui/dialogs/historyviewer.py", line 196, in showDiffs dlg = DiffViewerDialog(self, self.repo, commita, commitb) File "/home/ginetto/.qgis2/python/plugins/geogig/gui/dialogs/diffviewerdialog.py", line 91, in init self.computeDiffs() File "/home/ginetto/.qgis2/python/plugins/geogig/gui/dialogs/diffviewerdialog.py", line 235, in computeDiffs self.computeLayerDiffs(self.allchanges.keys()[0]) File "/home/ginetto/.qgis2/python/plugins/geogig/gui/dialogs/diffviewerdialog.py", line 266, in computeLayerDiffs execute(_computeLayerDiff) File "/home/ginetto/.qgis2/python/plugins/geogig/gui/executor.py", line 61, in execute return func() File "/home/ginetto/.qgis2/python/plugins/geogig/gui/dialogs/diffviewerdialog.py", line 244, in _computeLayerDiff self.createTableDataFromLayers() File "/home/ginetto/.qgis2/python/plugins/geogig/gui/dialogs/diffviewerdialog.py", line 204, in createTableDataFromLayers featuredict[GEOMETRY_FIELD][1] = QgsGeometry(feature.geometry()) TypeError: arguments did not match any overloaded call: QgsGeometry(): too many arguments QgsGeometry(QgsGeometry): argument 1 has unexpected type 'NoneType'

volaya commented 8 years ago

So the changes where the first commit of that layer, right?

luipir commented 8 years ago

right

but probably could be also records without geometry... I would check

alexbruy commented 8 years ago

Seems fixed in master. Please reopen if necessary