planetfederal / qgis-geogiglight-plugin

GNU General Public License v2.0
19 stars 9 forks source link

remove "geogig > add layer to repository" from contextual menu of layers that are not geopackages? #25

Closed gioman closed 8 years ago

gioman commented 8 years ago

The message that is returned in such cases is ok:

Only geopackage layers are supported at the moment I wonder if it would be better to not show at all the menu entry.

gioman commented 8 years ago

As suggest by Victor another option would be give users an option like "do you want to create a copy of this layer as Geopackage and start using it with Geogig?"

volaya commented 8 years ago

I like the warning dialog idea because, even it it is frustrating and might seem that is not needed ("why does it lets me try to add the layer if it is not a geopackage?"), it is informative. Otherwise, I predict many users 8who do not read the docs) will complain about it or report bugs saying that the plugin is broken and doesnt show the menu for their shapefiles, etc

Another option might be to add the menu, but disabled, so they can infere that with that type of layer that option is not available. Thoughts on that?

gioman commented 8 years ago

Otherwise, I predict many users 8who do not read the docs) will complain about it or report bugs saying that the plugin is broken and doesnt show the menu for their shapefiles, etc

yes, you are right.

Another option might be to add the menu, but disabled, so they can infere that with that type of layer that option is not available. Thoughts on that?

seems a reasonable option (it spares a click and a message in a dialog that must be followed by another click), not sure it will spare us from tickets saying that the plugin does not works for shapes, postgis et al. :)

volaya commented 8 years ago

this can be closed (looks like it wasn't automatically closed from the commit message)