search

planetfederal / qgis-geogiglight-plugin

GNU General Public License v2.0
19 stars 9 forks source link

"REPOS_FOLDER" parameter is not used if manually changed #83

Closed gioman closed 7 years ago

gioman commented 7 years ago

It seems that in the new dialog that allows to set the server URL and temp repos folder, the parameter for the folder is not taken into account if manually changed. If the default path for the temp repos folder is used (~/geogig/server) it works ok.

gioman commented 7 years ago

Just a side note: in the VM where testing will be made this path will point to a (virtualization software) shared folder. If the VM is Windows the path is normally as simple as "z:" (a drive letter is automatically given) while on macOS it can be as ugly as "/Volumes/VMware\ Shared\ Folders/server". It is necessary to be sure that such cases are also well handled by the plugin.

gioman commented 7 years ago

Just a side note: in the VM where testing will be made this path will point to a (virtualization software) shared folder. If the VM is Windows the path is normally as simple as "z:" (a drive letter is automatically given) while on macOS it can be as ugly as "/Volumes/VMware\ Shared\ Folders/server". It is necessary to be sure that such cases are also well handled by the plugin.

using an old revision (without the dialog for server url and repo folder) I was able to run the test under Windows using one of the tests VMs (by using as path "z:\shared_folder...") but the same didn't worked in a macOS VM.

gioman commented 7 years ago

This can be closed now as works as expected. Is still a little tricky in Os X/macOS testing VMs, but this can be easily be solved using a soft link.