wrong buttons alignment in compiled webapps

[gioman]

[bartvde]

@volaya we should probably add ToolbarSeparator in between in the app_writer I need to export those in the full build as well and we would need to import them

[volaya]

Can you copy here the import line to add?

On Thu, Mar 30, 2017 at 12:32 PM, Bart van den Eijnden < notifications@github.com> wrote:

@volaya https://github.com/volaya we should probably add ToolbarSeparator in between in the app_writer I need to export those in the full build as well and we would need to import them

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/boundlessgeo/qgis-webappbuilder-plugin/issues/293#issuecomment-290370878, or mute the thread https://github.com/notifications/unsubscribe-auth/ACARk7brxjFFcRHOz2IgwKLBWtS9SHJYks5rq4SlgaJpZM4MuIjJ .

-- Victor Olaya Software Engineer | Boundless http://boundlessgeo.com/ volaya@boundlessgeo.com @boundlessgeo http://twitter.com/boundlessgeo/

[bartvde]

Sure:

import {ToolbarGroup, ToolbarSeparator} from 'material-ui/Toolbar';

instead of:

import {ToolbarGroup} from 'material-ui/Toolbar';

[bartvde]

and then we need a structure like:

<ToolbarGroup<Button /></ToolbarGroup>
<ToolbarSeparator/>
<ToolbarGroup><Button /></ToolbarGroup>

etc. but then with React.createElement

[bartvde]

No you also need to change the appwriter to actually insert the separators

[volaya]

ah, ok...too fast :-)

just let me know how that should be done and i will take care of it

[bartvde]

where you have:

tools = ["React.createElement(ToolbarGroup, undefined, %s)" % t for t in app.tools]

something like

tools = ["React.createElement(ToolbarGroup, undefined, %s), "React.createElement(ToolbarSeparator)" % t for t in app.tools]

?

[untested]

[volaya]

ok, let me try

[volaya]

should be done now

[bartvde]

looks like they might need to get wrapped in a ToolbarGroup as well

[bartvde]

yes so @volaya can you change React.createElement(ToolbarSeparator),

to become:

React.createElement(ToolbarGroup, undefined, React.createElement(ToolbarSeparator)),

TIA

[gioman]

@volaya @bartvde just updated the plugin, now adding any widget that adds a button in the header will return a blank preview, while the compiled webapp is ok.

[bartvde]

@gioman did you update from master?

[bartvde]

i.e. SDK master

[bartvde]

I changed the first button manually by wrapping the ToolbarSeparator in a ToolbarGroup and it looks good then:

[bartvde]

@volaya see my PR here: https://github.com/boundlessgeo/qgis-webappbuilder-plugin/pull/298

[gioman]

@gioman did you update from master?

disregard my comment, wrong paver command.

[gioman]

can we close this?

[bartvde]

yes