planetfederal / qgis-webappbuilder-plugin

GNU General Public License v3.0
18 stars 20 forks source link

Missing check for CORS for WMS layers #295

Closed gioman closed 7 years ago

gioman commented 7 years ago

The result of adding a WMS from a server with no CORS is that the application returns the error:

There was an error loading tiles.

The necessity of CORS on the server side must also be documented (as also for WFS, there is a separate ticket for that) @SrNetoChan

volaya commented 7 years ago

I am no expert on that, but why do you need the CORS check for WMS? We are checking it for WMS layers, only if there is a popup for that layer, since that makes sense, but otherwise, i guess it is not needed, right?

@bartvde?

Anyway, if it has to be done, i can do it easily

On Thu, Mar 30, 2017 at 12:28 PM, Giovanni Manghi notifications@github.com wrote:

The result of adding a WMS from a server with no CORS is that the application returns the error:

There was an error loading tiles.

The necessity of CORS on the server side must also be documented (as also for WFS, there is a separate ticket for that) @SrNetoChan https://github.com/SrNetoChan

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/boundlessgeo/qgis-webappbuilder-plugin/issues/295, or mute the thread https://github.com/notifications/unsubscribe-auth/ACARkwdv7CS3JxL61pqkqm9BA4nUI90xks5rq4PcgaJpZM4MuKl_ .

-- Victor Olaya Software Engineer | Boundless http://boundlessgeo.com/ volaya@boundlessgeo.com @boundlessgeo http://twitter.com/boundlessgeo/

bartvde commented 7 years ago

CORS is needed otherwise we cannot print or export to PNG

gioman commented 7 years ago

CORS is needed otherwise we cannot print or export to PNG

is not also the reason behind the "There was an error loading tiles" error?

bartvde commented 7 years ago

@gioman just to be sure, can you attach an app that shows this?

gioman commented 7 years ago

webapp.zip