search

planetfederal / qgis-webappbuilder-plugin

GNU General Public License v3.0
18 stars 20 forks source link

webapp does not work and makes crash IE11 #403

Open gioman opened 7 years ago

gioman commented 7 years ago

Seen trough a web server (apache). This is the webapp as generated by the new manual test (tester plugin) "osm".

cb8876bcc68d4ea4b4a878b87f078c26.zip

bartvde commented 7 years ago

selection_282

@volaya this looks like yours

volaya commented 7 years ago

The app in that zip file works perfectly with no error in the js console, both if i open it directly or if i serve ir (using python SimpleHTTPServer)

How do you get that error, @bartvde

Line 410 is correct, but apparently missing a semicolon at the end. I I fixed that. Maybe your browser (I am using Chrome) is less tolerant to that?

gioman commented 7 years ago

@volaya possibly, this report is specific for IE11, on other browsers (FF, Chrome) is ok.

bartvde commented 7 years ago

right this was IE, and IE is sensitive to that

bartvde commented 7 years ago

so probably needs to be retested on WAB master right?

gioman commented 7 years ago

@bartvde just retested on master, no changes.

webapp.zip

ea1c2f297a084d74aa59687c264e457a.zip

gioman commented 7 years ago

@bartvde @volaya even with changes that fixed https://github.com/boundlessgeo/qgis-webappbuilder-plugin/issues/409 this is a no go

screenshot_20170531_122406

58fc04d67b1c4d1cb96fc9eece1f641a.zip

webapp.zip

bartvde commented 7 years ago

ok checking your zips

bartvde commented 7 years ago

yeah I get the same in IE11

bartvde commented 7 years ago

can we pinpoint this somehow to some of the functionality @gioman I wonder if it's caused by the rendering extensions or something else

gioman commented 7 years ago

the webapp has no widgets, overlays or basemaps active.

bartvde commented 7 years ago

can we check a project without the rendering extensions in it?

bartvde commented 7 years ago

@volaya this is only added in the basic theme right?

gioman commented 7 years ago

can we check a project without the rendering extensions in it?

I have checked several simple projects and beside a few glitches/problems (see layer list) they worked on IE11.

bartvde commented 7 years ago

@gioman can you check this exact same project with the tabbed theme?

bartvde commented 7 years ago

it's caused by the pattern fills based on svg

gioman commented 7 years ago

@bartvde so no need to test the tabbed version?

gioman commented 7 years ago

@bartvde @volaya trying to compile this project in tabbed mode fails:

2017-05-31T08:04:44 2   WebAppBuilder: Cannot build webapp: Network error #400: Error downloading https://api.boundlessgeo.io/v1/websdk/package - server replied: SyntaxError: /tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/app.jsx: Unexpected token (2017:109)
                                                                                ref:"table", pointZoom:16, map: map,
                                                                                sortable:true, pageSize:20})
                                            )], open: this.state.leftNavOpen, onRequestClose: this.leftNavClose.bind(this}),
                  React.createElement("div", undefined,
                    React.createElement(Header, toolbarOptions ),
                    React.createElement("div", {className: 'map', style: {left: this.state.leftNavOpen ? leftNavWidth : 0, width: this.state.leftNavOpen ? 'calc(100% - ' + leftNavWidth + 'px)' : '100%'}},
                at Parser.pp.raise (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/location.js:24:13)
                at Parser.pp.unexpected (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/util.js:82:8)
                at Parser.pp.expect (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/util.js:76:33)
                at Parser.pp.parseExprList (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/expression.js:785:12)
                at Parser.pp.parseSubscripts (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/expression.js:270:29)
                at Parser.pp.parseExprSubscripts (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/expression.js:240:17)
                at Parser.pp.parseMaybeUnary (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/expression.js:217:19)
                at Parser.pp.parseExprOps (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/expression.js:163:19)
                at Parser.pp.parseMaybeConditional (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/expression.js:145:19)
                at Parser.pp.parseMaybeAssign (/tmp/websdk/f3064414-eaa9-46b6-bffc-61d24b906ba8/webapp/node_modules/babylon/lib/parser/expression.js:112:19)
bartvde commented 7 years ago

can you attach the app.jsx file?

bartvde commented 7 years ago

can you attach the app.jsx file?

volaya commented 7 years ago

This can be fixed by exporting svgs to pngs like we do for markers. However, this might not be ready for release, so I suggest leaving it like that and documenting this limitation (svg pattern fills + IE).

I have opened a JIRA ticket to address this later and not forget about it

@SrNetoChan what o you think?

gioman commented 7 years ago

can you attach the app.jsx file?

@bartvde attached

app.jsx.zip

SrNetoChan commented 7 years ago

@volaya I have documented in here:

https://github.com/boundlessgeo/qgis-webappbuilder-plugin/commit/47b41b1b580dc4b4a930104eee623992034714e8

Is it ok?

bartvde commented 7 years ago

ah looks to be the trailing frontal comma on the tablist:


tabList: [,
React.createElement```
bartvde commented 7 years ago

no sorry it's this line:

this.leftNavClose.bind(this}) will fix in WAB