planetfederal / wps-gui

Graphical User Interface (Model Builder) for OGC:WPS (Web Processing Services)
http://boundlessgeo.com
Apache License 2.0
26 stars 15 forks source link

polygon extraction appending error with the correct output #105

Closed sbalasub closed 9 years ago

sbalasub commented 9 years ago

polygon extraction process gets enabled with just entering one of the required input 'data'. But the error for null range value gets thrown on executing it ' Process failed during execution Process execution 42bc4cd9-e356-4bf5-8d49-e3a4caae2ec8 failed Failed to retrieve value for input ranges Bad range definition 'null' null'. On correcting this error and reexecuting with data and range value (0;1000), the correct output gets displayed along with the error got before as shown image

bartvde commented 9 years ago

okay something indeed goes wrong here with marking the process as complete, will investigate

bartvde commented 9 years ago

okay they are actually not required, so the colour is wrong in the UI:

            <Input maxOccurs="2147483647" minOccurs="0">
                <ows:Identifier>nodata</ows:Identifier>
                <ows:Title>nodata</ows:Title>
                <ows:Abstract>Value to treat as NODATA (default is 0)</ows:Abstract>
                <LiteralData>
                    <ows:AnyValue/>
                </LiteralData>
            </Input>
            <Input maxOccurs="2147483647" minOccurs="0">
                <ows:Identifier>ranges</ows:Identifier>
                <ows:Title>ranges</ows:Title>
                <ows:Abstract>Specifier for a value range in the format ( START ; END ).  START and END values are optional. [ and ] can also be used as brackets, to indicate inclusion of the relevant range endpoint.</ows:Abstract>
                <LiteralData>
                    <ows:AnyValue/>
                </LiteralData>
            </Input>
bartvde commented 9 years ago

okay so tiff download needs to clear the results panel as well, will fix

bartvde commented 9 years ago

@dwins any ideas on whether or not ranges should be required in this process (PolygonExtraction) in geoserver WPS? Since it throws a runtime exception if ranges is not set? If you think this is an issue, we can open up a new one for that specific case.

dwins commented 9 years ago

I haven't reviewed this ticket yet. Was it meant to be closed?

bartvde commented 9 years ago

@dwins reopened just now, but if you think it is an issue as well we might be better off creating a new one I guess.

dwins commented 9 years ago

The process implementation explicitly tests whether the ranges are provided, so I think it is intended to work without them.