Boundary process doesn't work with any geometry

[sbalasub]

Boundary process doesn't work with any geometry.

[sbalasub]

centroid also has the same issue

[bartvde]

For boundary the issue is that GeoServer sends WKT which does not comply to the spec, I need to check with @jdeolive how we can handle this:

Uncaught Error: Invalid geometry type: LINEARRING

LINEARRING (-7748880.179438027 939258.2035682453, -704443.6526761837 1956787.9241005117, -626172.1357121635 -4070118.8821290648, -8375052.315150191 -4539747.983913188, -7748880.179438027 939258.2035682453)

Request:

<p0:Execute xmlns:p0="http://www.opengis.net/wps/1.0.0" service="WPS" version="1.0.0"><p1:Identifier xmlns:p1="http://www.opengis.net/ows/1.1">geo:boundary</p1:Identifier><p0:DataInputs><p0:Input><p1:Identifier xmlns:p1="http://www.opengis.net/ows/1.1">geom</p1:Identifier><p0:Data><p0:ComplexData mimeType="application/wkt">POLYGON((-7748880.179438027 939258.2035682453,-704443.6526761837 1956787.9241005117,-626172.1357121635 -4070118.8821290648,-8375052.315150191 -4539747.983913188,-7748880.179438027 939258.2035682453))</p0:ComplexData></p0:Data></p0:Input></p0:DataInputs><p0:ResponseForm><p0:RawDataOutput mimeType="application/wkt"><p1:Identifier xmlns:p1="http://www.opengis.net/ows/1.1">result</p1:Identifier></p0:RawDataOutput></p0:ResponseForm></p0:Execute>

Centroid works for me but the OSM basemap does not load since it's zoomed in too far (it uses the extent of the single point geometry), I'll ticket this separately though.

[jdeolive]

I think we should get a fix in on the server to deal with this for now. Longer term fix would probably be to push down into JTS and have the WKT encoder work in a "standard" mode. Let's work with @adunetz to get this resourced.

[sbalasub]

This affects exteriorRing process as well

[dwins]

The correct encoding should be LINESTRING instead of LINEARRING, correct? Are there any other invalid geometry types being generated by JTS's WKTWriter?

[bartvde]

correct, I haven't seen any other cases as yet, and don't expect them given the comment in here:

http://www.vividsolutions.com/Jts/javadoc/com/vividsolutions/jts/io/WKTWriter.html

A non-standard LINEARRING tag is used for LinearRings. The SFS WKT spec does not define a special tag for LinearRings. Under it, rings are output using LINESTRING.

[dwins]

Ok, I have a fix. Which version of geoserver should I issue a PR for? Do I need to make a PR against the boundless fork?

[bartvde]

not sure so pinging @jdeolive here, I guess the same as what he's doing for the SFMTA download TIFF work?

[jdeolive]

Pull request against community repo and we can pull into boundless fork as necessary.

On Wed, Sep 17, 2014 at 9:59 AM, Bart van den Eijnden < notifications@github.com> wrote:

not sure so pinging @jdeolive https://github.com/jdeolive here, I guess the same as what he's doing for the SFMTA download TIFF work?

— Reply to this email directly or view it on GitHub https://github.com/boundlessgeo/wps-gui/issues/48#issuecomment-55916189.

Justin Deoliveira VP Engineering | Boundless http://boundlessgeo.com/ jdeolive@boundlessgeo.com @boundlessgeo http://twitter.com/boundlessgeo/

[dwins]

PR submitted and accepted in GeoServer master. https://github.com/geoserver/geoserver/pull/753

[bartvde]

nice @dwins what step is needed to get this onto horizon as well?

[dwins]

We need to get it merged into the Suite repo and wait, I think.