Fix missing assignment in initFromJson for Option[T]

planetis-m / eminim

JSON serialization framework for Nim, works from a Stream directly to any type and back. Depends only on stdlib.

Other

37 stars 6 forks source link

Fix missing assignment in initFromJson for Option[T] #6

Closed sebbert closed 3 years ago

sebbert commented 3 years ago

When attempting to deserialize into an Option[T], I get:

C:\Users\Sebbert\.nimble\pkgs\eminim-2.5.1\eminim.nim(237, 16) Error: expression 'none()' is of type 'Option[system.string]' and has to be used (or discarded)

This PR adds the missing assignment here

planetis-m commented 3 years ago

Thank you for the PR! Today I noticed this too, it's already fixed in v2.6.0

sebbert commented 3 years ago

Awesome, thanks for the quick reply :)