planetlabs / planet-client-python

Python client for Planet APIs
https://planet-sdk-for-python-v2.readthedocs.io/en/latest/
Apache License 2.0
276 stars 92 forks source link

get_results_csv limit parameter has no effect #1070

Closed tbarsballe closed 1 month ago

tbarsballe commented 1 month ago

Expected behavior As this request is returning a single document, I would not expect this parameter to be present

Actual behavior (describe the problem) The limit parameter of SubscriptionsClient().get_results_csv() is not described in the documnetation. More importantly, the parameter is never actually used in the code

While this is technically a backwards-incompatible change in the SDK, I think the cleanest solution would be to just remove the parameter

Related Issues

1069