search

planetlabs / qgis-planet-plugin

Browse, filter, preview and download Planet Inc imagery in QGIS.
https://developers.planet.com/docs/integrations/qgis/
GNU General Public License v2.0
45 stars 12 forks source link

Fix area coverage filtering bug #119

Closed Samweli closed 1 year ago

Samweli commented 1 year ago

The area coverage filtering in the plugin doesn't use the correct comparison when filtering out the found result images. This PR updates the area coverage value comparison with minimum and maximum values submitted in the search request.

Note: One of the unexpected operations is that the area coverage filtering is done post search see https://github.com/planetlabs/qgis-planet-plugin/blob/9217a94737b0e0d063151ffdde2f819c5216921d/planet_explorer/gui/pe_dailyimages_search_results_widget.py#L264, it would have been nice for this kind of filtering to be done in the Planet API and the returned resultset to already be filtered.

Screenshot of the current behaviour bug_area_coverage_filtering

Screenshot of the fixed behaviour fixed_area_coverage_filter

Samweli commented 1 year ago

Hi @john-dupuy, We aim for thie PR to be in the final fix for the 2.3.0 release which we are planning to release today or tomorrow. thanks.

Samweli commented 1 year ago

Thanks @john-dupuy