search

planetlabs / qgis-planet-plugin

Browse, filter, preview and download Planet Inc imagery in QGIS.
https://developers.planet.com/docs/integrations/qgis/
GNU General Public License v2.0
45 stars 10 forks source link

Toggling selection tool cause an error #120

Closed Samweli closed 1 year ago

Samweli commented 1 year ago

Clicking the selection tool for first time without any active layer result into plugin error.

This is caused by access of uninitialized variable here https://github.com/planetlabs/qgis-planet-plugin/blob/9217a94737b0e0d063151ffdde2f819c5216921d/planet_explorer/gui/pe_filters.py#L737

cc @Jeremy-Prior @vermeulendivan

Screenshot of the error issue_toggling_selection

vermeulendivan commented 1 year ago

@Samweli Hey. Thanks for showing this. It happens with me even if a layer is active. The function here def _toggle_selection_tools(self): - the _toggle_selection_tools is no longer required because of changes. This issue does not happen if you click on the drop down arrow, likely why it went unnoticed. Will have the fix ready shortly.

Samweli commented 1 year ago

@Samweli Hey. Thanks for showing this. It happens with me even if a layer is active. The function here def _toggle_selection_tools(self): - the _toggle_selection_tools is no longer required because of changes. This issue does not happen if you click on the drop down arrow, likely why it went unnoticed. Will have the fix ready shortly.

@vermeulendivan alright, thanks in advance for the fix.

vermeulendivan commented 1 year ago

@Samweli Issue has been fixed. Here is the PR: https://github.com/planetlabs/qgis-planet-plugin/pull/122

Screencast from 09-02-2023 15:12:48.webm