planetlabs / qgis-planet-plugin

Browse, filter, preview and download Planet Inc imagery in QGIS.
https://developers.planet.com/docs/integrations/qgis/
GNU General Public License v2.0
45 stars 12 forks source link

Composite checkout function for orders #134

Closed vermeulendivan closed 1 year ago

vermeulendivan commented 1 year ago

Fixes #131

Adds an option for the user when applying for an order to composite the satellite data. This is based on how it looks in ArcMap (example received).

Composite option: image

Composite raster added to canvas using the Add to map button: image

john-dupuy commented 1 year ago

@vermeulendivan It seems that orders that have the "composite" checkbox clicked do not get submitted even though the order dialog says that they were submitted.

Kazam__00007.webm

vermeulendivan commented 1 year ago

@john-dupuy @Samweli Thanks for the feedback. This is the same what happened to me when using any of the Planet accounts we have. Clipping does the same. The problem is a result of a permission issue (not all accounts are allowed to use clipping or composite), which has been discussed with Asa, Barbara, and Ryan. So not related to the plugin itself. This is also why there are no error on the plugin's side when the request is done, because its the API/server blocking the order because of permission issues with the account. Asa tested this with his account and it works perfect. There is a long discussion on Slack about this, I linked the discussion in Slack for you to have a look at.

john-dupuy commented 1 year ago

Thanks for the explanation @vermeulendivan - looks like it's working with my planet account. Curious if you want to do the error / notification handling in this PR or in a follow-up?

john-dupuy commented 1 year ago

I noticed the Add to Map button does not work for composited orders, I expect because the tif file has a different name? composite.tif

vermeulendivan commented 1 year ago

@john-dupuy Did respond on Slack, but thought I will get to you here as well.

An update has been added to take into account the composite.tif file name, which worked fine for Asa and me. I'm assuming the issue you are getting are also a result of the manifest file which differs (for composite data the annotations are empty!). Can you maybe send me the manifest file(s) for the downloaded data causing the issue on Slack? It will help a lot as I cannot place orders via the plugin because of the permission issue.

On the error message, I had a quick look and your suggestion on how to show the error message should work great. I will add it for clipping as well, as the same problem happens when clipping is enabled. Its strange that this has not been added to the plugin for clipping, and the plugin will actually show that the order went through with no issue even though clipping is not allowed.

vermeulendivan commented 1 year ago

@john-dupuy @Samweli Following improvements has been implemented:

Error message for Composite: image

Error message for clipping: image