search

planetlabs / qgis-planet-plugin

Browse, filter, preview and download Planet Inc imagery in QGIS.
https://developers.planet.com/docs/integrations/qgis/
GNU General Public License v2.0
45 stars 12 forks source link

CI test errors against pull requests #62

Closed Samweli closed 1 year ago

Samweli commented 1 year ago

Current CI workflow raises errors when it runs agains pull requests made by users who don't have full access to the plugin repository.

The following errors have appeared in the recent submitted PRs.

john-dupuy commented 1 year ago

Hi @Samweli - thanks for the bug report.

Failing due to long running time, some tests matrix timeout at 3mins and 28/29 secs - https://github.com/planetlabs/qgis-planet-plugin/actions/runs/3375040820/jobs/5601295038#step:3:204

I believe this is because of the last issue "No access to planet credentials"

Missing py package, in some PRs running docker tests throws an exception about not finding the py module - https://github.com/planetlabs/qgis-planet-plugin/actions/runs/3376868140/jobs/5605108944#step:3:176

It looks like there was an update that broke the install step - investigating.

john-dupuy commented 1 year ago

For the no access to planet credentials - pull requests on this repository must be submitted via a branch of the repo so that it has access to those credentials. Please let me know if you're able to submit pull requests in this way.

john-dupuy commented 1 year ago

https://github.com/planetlabs/qgis-planet-plugin/pull/65 addresses:

Samweli commented 1 year ago

65 addresses:

Thanks @john-dupuy

Samweli commented 1 year ago

Closed via https://github.com/planetlabs/qgis-planet-plugin/pull/65