planetlabs / qgis-planet-plugin

Browse, filter, preview and download Planet Inc imagery in QGIS.
https://developers.planet.com/docs/integrations/qgis/
GNU General Public License v2.0
45 stars 12 forks source link

black/flake8 clashes fix #84

Closed vermeulendivan closed 1 year ago

vermeulendivan commented 1 year ago

Cause of the issue: https://black.readthedocs.io/en/stable/faq.html#why-are-flake8-s-e203-and-w503-violated, 'Why are Flake8's E203 and W503 violated?'. E203 is the error with whitespace characters before ':', black adds a whitespace before ':', causing a conflict with flake8. This removes this change made by black. E501 is line length, because the line length of flake8 and black differs. Both these changes are recommended on the black page provided above so that flake8 and black can have no clashes. https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html

Also updated flake8 and black to make use of the latest versions.

vermeulendivan commented 1 year ago

@john-dupuy These minor changes is to fix the clashes between flake8 and black. Basically this issue was noted with the add to map button PR. So what happens is that black adds a space before a ':' character, which causes flake8 to break. These changes is suggested by black (see the PR description for more details) to solve the problem and allow black and flake8 together.