planetoftheweb / podcast-generator

Generates podcast feeds using YAML, hosted by GitHub pages.
MIT License
19 stars 15 forks source link

Update Dockerfile #2

Open rabiejavadian opened 6 months ago

mjbear commented 1 month ago

Now that I'm on the correct PR for my comment. :sweat_smile:

@rabiejavadian I'm not looking to take away from your solution. (Really cool!)

Another alternative is to simply comment out the pip3 install PyYAML line and add python3-yaml to the earlier apt-get command.

RUN apt-get update && apt-get install -y \
    python3.10 \
    python3-pip \
    git \
    python3-yaml

For a temporary container a simple solution might be more desirable.

mjbear commented 1 month ago

@planetoftheweb What might your preferences or thoughts be on fixing the Dockerfile?

  1. Add python3-yaml to the apt-get command?
  2. Add extra lines for a virtual environment and installing PyYAML in that venv?
    • plus having to modify the entrypoint.sh shell script
Ray Romano saying What do you think?
mjbear commented 1 week ago

The inclusion of pyyaml with the apt-get command means one less Docker image layer which is also a plus! :grinning:

https://emmer.dev/blog/reducing-docker-layers/

@planetoftheweb