Closed marissamarym closed 2 years ago
@marissamarym is attempting to deploy a commit to the PlanetScale Team on Vercel.
A member of the Team first needs to authorize it.
Hi @marissamarym, thanks for taking the time to implement this and submit a PR.
For now, we'd prefer to keep the Slack notifications lightweight and simple. Would you be interested in updating your code to generate the same sort of summary snippet that is shown on the listings page? I think it's as simple as pulling the first tag out of the content.
Hi @marissamarym, thanks for taking the time to implement this and submit a PR.
For now, we'd prefer to keep the Slack notifications lightweight and simple. Would you be interested in updating your code to generate the same sort of summary snippet that is shown on the listings page? I think it's as simple as pulling the first tag out of the content.
Sure! I changed it so it just takes the first element and does some light filtering of the elements so it's not previewing the first H1.
How closely should I match the listings page? I can add filters for the same elements ['p', 'ul', 'ol', 'h3', 'pre', 'img']
. And should I add a Continue reading >
tag when there's more content?
Thanks @marissamarym. I think this is great as-is.
@bogdansoare Would you mind giving this a review before merging? 🙏🏼
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/planetscale/beam/4BZJgsuj3mPefrWDpLmWrMStzwKQ
✅ Preview: https://beam-git-fork-marissamarym-main.preview.planetscale.com
Hey @marissamarym. Thank you for opening this PR ❤️, adding the summary to the slack notification would be a nice addition.
The only issue that I see is in regards to the dependencies of mack, because of the usage of remark
and rehype
, the package size is quite big https://bundlephobia.com/package/@instantish/mack@1.1.4.
We decided not use those libraries for markdown and go for marked because of it's smaller size and speed.
It would be great if you could find an alternative that is either based on marked
or something smaller in bundle size.
Hey @marissamarym. Thank you for opening this PR ❤️, adding the summary to the slack notification would be a nice addition.
The only issue that I see is in regards to the dependencies of mack, because of the usage of
remark
andrehype
, the package size is quite big https://bundlephobia.com/package/@instantish/mack@1.1.4.We decided not use those libraries for markdown and go for marked because of it's smaller size and speed.
It would be great if you could find an alternative that is either based on
marked
or something smaller in bundle size.
Sorry for the delay on this, our team is currently working on improving mack as well as some of our other projects to be smaller and use marked. If it works for you, we could close this PR and I'll open another when that's ready
@marissamarym No worries at all. Feel free to close this and open another anytime. :thumbsup:
We recently upgraded mack to be ~1/4 the size and it uses marked
now: https://bundlephobia.com/package/@instantish/mack@1.2.0
@marissamarym thanks for updating the PR to include the new version of mack, it looks good 👍
Closes #47
Demo
Slack notification
Beam post
Changes