planetscale / ghcommit-action

GitHub Action to commit files to a git branch using the ghcommit utility
Apache License 2.0
30 stars 4 forks source link

Index and Tree status not detected #43

Open nicholas-cwb opened 10 months ago

nicholas-cwb commented 10 months ago

When I open a PR from feat branch to main, github action will run. I can see the files changed but during the autocommit stage I get the following.

Filename: artefact.txt
Index Status: ?
Tree Status: ?
Filename: artefact.txt
-----------------------------
No changes detected, exiting

My github action:

name: fmt

on:
  pull_request:
    branches:
       - main

jobs:
  generate-txt:
    runs-on: ubuntu-latest

    permissions:
      contents: write

    steps:
      - uses: actions/checkout@v3

      # Run steps that make changes to the local repo here.

      # Commit all changed files back to the repository
      - uses: planetscale/ghcommit-action@v0.1.6
        with:
          commit_message: "generate txt"
          repo: ${{ github.repository }}
          branch: ${{ github.head_ref || github.ref_name }}
        env:
          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

Somehow it detectes the filename but index and tree status is ? My repository is private under an organization. Any possible rootcause to this behavior? Maybe some organization github enterprise repository setting that is might contribute to this issue.

I chanced upon this article https://groups.google.com/g/git-for-windows/c/TdM_VLjK8AA regarding git config -global -add safe.directory "$GITHUB_WORKSPACE" line in the action shell script. Maybe it is related to the issue.

slavamak commented 8 months ago

I've also had this issue. This is because the action script does not handle untracked files in any way. I guess if we added something like this, it would work.

  # handle untracked (??):
  [[ "$tree_status" == "?" && "$index_status" == "?" ]] && adds+=("$filename")

But I'm not sure if that would break anything. Maybe it was omitted intentionally for some reason. @joemiller is there any chance you could take a look at this when you have time?

arunsathiya commented 1 month ago

Unless I am misunderstanding something, would this be as easy as staging the changes with this step?

https://github.com/arunsathiya/portfolio/blob/eaf53d63aafbfe7e0a64125bcc0a9addfa3ff2a7/.github/workflows/notion.yml#L61-L63

joemiller commented 1 week ago

If anyone is willing to submit a PR with a proposed fix + bats test case I would be happy to review it.