add build workflow - Githubissues

planetscale / vitess-releases

Vitess releases

Apache License 2.0

30 stars 6 forks source link

add build workflow #22

Closed maxenglander closed 2 years ago

maxenglander commented 2 years ago

Run buid-vitess-packages.sh --dry-run on PR or push to master branch via a new GH action.

This PR makes some changes to the build script, Dockerfile, and devcontainer manifest:

Previously devcontainer features could not be used to install Golang the way we needed.
With this PR, we're now using features to install Golang. Seems to work.
Previously we were doing chmod -R /go to make sure we had the right user perms on files installed there.
With this PR we no longer install any binaries to /go. All binaries are build in either $VTROOT or $HOME.

To add some confidence to these changes:

The new GH action is passing.
I launched a fresh code space with the latest changes and ran build-vitess-packages.sh --dry-run. Works.
Inspected the resulting packages and verified correct user (planetscale) is set on all files.