search

planetteamspeak / ts3phpframework

Modern use-at-will framework that provides individual components to manage TeamSpeak 3 Server instances
https://www.planetteamspeak.com
GNU General Public License v3.0
212 stars 59 forks source link

Dev #145

Closed Sebbo94BY closed 4 years ago

Sebbo94BY commented 4 years ago
Sebbo94BY commented 4 years ago

Mhmmm... Any idea, how we can install the PHP extension ssh2 in Travis CI?

As soon as this is available, the builds should be fine.

ronindesign commented 4 years ago

I'm ok with merging these changes to the README only on the dev branch. We'll need to have approval from @svenpaulsen before this get's merged into master though, as the README is basically the front page for the framework and he'll need the final say if he wants Travis CI status displayed there, etc.

EDIT: Just saw you're still working on ssh2 functionality, so I'll hold off merging this until that has been addressed.

ronindesign commented 4 years ago

RE: ssh2 - looks like there was some workaround for getting ssh2 to work, but possibly (as of late last year) Travis CI has moved to using phpseclib[1]]. It looks like phpseclib would be suitable[2][3] replacement, but I imagine PECL ssh2 extension everyone is more familiar/comfortable with. So, I think it makes more sense to try and get ssh2 extension to work in Travis CI still, maybe even if we have to compile from source...

Ref: [1] https://github.com/DivineOmega/php-ssh-connection/issues/2 [2] https://stackoverflow.com/questions/14304234/phpseclib-or-ssh2-pecl-extension [3] http://phpseclib.sourceforge.net/ssh/compare.html

Sebbo94BY commented 4 years ago

Finally! https://travis-ci.org/github/planetteamspeak/ts3phpframework/builds/688096095

I'm unfortunately not that familiar with the configuration of composer.json, so I don't know how we can solve these dependency issues. Maybe someone else has an idea.

Anyway: Except of those php-cs / coverage issues, the library seems to be fine and working. I've also replaced the deprecated curly braces with square brackets for PHP 7.4 (#148).

Can you merge those changes for now into dev only, that I can test, if this solves the issue #137?

@svenpaulsen can update the README or anything else later as well, before it gets merged into master. :)

ronindesign commented 4 years ago

Looks great! Thanks for sticking with the ssh issue to get it resolved and for the work on refactoring curly braces to brackets, really appreciate it!

Sebbo94BY commented 4 years ago

Thanks for merging! I'll test and try to fix the issue #137 next. Hopefully this weekend. :)