search

planetteamspeak / ts3phpframework

Modern use-at-will framework that provides individual components to manage TeamSpeak 3 Server instances
https://www.planetteamspeak.com
GNU General Public License v3.0
211 stars 59 forks source link

PHP 8.2: Function utf8_encode() is deprecated #198

Closed Sebbo94BY closed 1 year ago

Sebbo94BY commented 1 year ago

Function utf8_encode() is deprecated in src/Helper/StringHelper.php on line 472

MatthiasHeinz commented 1 year ago

A possible fix for

Function utf8_encode() is deprecated in src/Helper/StringHelper.php on line 472

might be $this->string = mb_convert_encoding($this->string, 'UTF-8', mb_list_encodings());.

Would have made a pull request, but I'm not too fluent in php and not aware of potential differences between the two functions.

Sebbo94BY commented 1 year ago

I've now merged my suggestion since the PHPUnit tests were successful and nobody complained about it. :)

MatthiasHeinz commented 1 year ago

Thanks so much for your work; I'm gonna test this when I get a chance (probably next week) and report back in case of any further issues.