Open beelauuu opened 1 year ago
nsandler1
commented
1 year ago No worries, thank you for doing this! I modified your description to close the corresponding issue and update the title of the PR to be a more descriptive.
You did exactly what the issue asked of you, but is it me or does something seem off about everything being centered? Maybe keep the search and pagination aligned left or right of the table? What are your thoughts @beelauuu?
beelauuu
commented
1 year ago @nsandler1 Hm. I actually just had the table centered at first but thought it looked pretty odd so I just changed some of the bootstrap CSS to center it and thought it looked better all centered
If you want I can uncenter the other parts except the table and recommit if you want to see how it looks!
nsandler1
commented
1 year ago No need, I trust your judgement. What are your thoughts about making the search bar and pagination thing extend to the full width the of table?
beelauuu
commented
1 year ago @nsandler1 Hm off the top of my head I can't really picture it. I'll play around with it tonight and let you know if I can get it to extend all the way and see how it looks!
beelauuu
commented
9 months ago @nsandler1 never responded about this haha whoops, but I think it looks better with it all centered.
tybug
commented
9 months ago I'm not sure I'm a fan of this, tbh. Compare:
| master | this pr |
|---|---|
I think having the search bar and page selector be centered looks weird, but left-aligning them would also probably look weird when everything else is centered.
beelauuu
commented
9 months ago Gotcha, what do you think I should do then? I agree they both look a little off (centered and left aligned)
Centered the tables as well as the searching feature and pagination on /tools/coursedifficulty @nsandler1
EDIT: I am so sorry for my horrible commit history lol. I reused my branch from last time and it became a humongous mess :/
Closes #130