Center professors listed on /course/

planetterp / PlanetTerp

a community for students at the university of maryland

https://planetterp.com

GNU Affero General Public License v3.0

41 stars 21 forks source link

Center professors listed on /course/ #95

Open nsandler1 opened 1 year ago

nsandler1 commented 1 year ago

The below example can be found here

saewitz commented 1 year ago

I prefer it as-is, centering it will be a bit uneven I think

tybug commented 1 year ago

hmm, am on the fence, leaning towards leaving it off-center as I agree it might look weird to have so many centered elements (the semester title and then the professor's name). Would probably have to see it.

nsandler1 commented 1 year ago

tybug commented 1 year ago

Dunno, as I thought it looks weird having that many centered elements. Also weird to not have all the cards aligned the same way (cards are in the center one row and to the side the next row).

gamesover commented 2 weeks ago

I understand the issue now. @nsandler1, could you please advise whether you'd like the professor's card to be centered when there is only one professor? If so, I'd like to push a PR.

Here are the proposed guidelines:

If there is only one professor, center the professor's card.
If there are multiple professors, maintain the current layout.

Personally, I really don't think there is any issue with current UI ;)